[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Arch Linux specific grub-mkconfig fixes

From: Keshav Padram Amburay
Subject: Re: [PATCH] Arch Linux specific grub-mkconfig fixes
Date: Tue, 10 Dec 2013 01:19:12 +0530

On Tue, Dec 10, 2013 at 12:47 AM, Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> wrote:
This patch clearly doesn't have right attributions, not split according
to functional changes and some of parts were already discussed.  As-is
patch is unacceptable, the biggest problem being the lack of right
attribution. E.g. some parts are apparently by WIP patch by Alexander
Kurtz yet he's never mentioned at all.
Please never ever send patches to GRUB under wrong authorship acknowledges.

I was not aware of WIP patch by Alexander Kurtz with respect to the GRUB_COLOR_* changes.

Regarding the code adding detection of Arch Linux kernel and initramfs files by grub-mkconfig, it is difficult to find out via the current Arch Linux SVN based repo structure as to who was the original author of this patch, and who all have contributed changes to it (apart from me, Tobias Powalowski and Ronald Van Haren), so for now I withdraw this patch. Sorry for the mistake.

On 09.12.2013 20:11, Keshav Padram Amburay wrote:
> Hi,
> This patch has been used in Arch Linux's GRUB(2) package for quite some
> time (ever since the release of grub 2.00).
> The main feature that distinguishes Arch Linux from other distros is
> that its kernel and initramfs (core/linux pkg) are always installed at
> /boot/vmlinuz-linux and /boot/initramfs-linux.img and this path does not
> contain the actual kernel version info and therefore does not change
> with kernel updates, unlike other distros.
> Also Arch Linux includes a secondary (fallback) initramfs image
> at /boot/initramfs-linux-fallback.img which contains modules, that are
> excluded by autodetect hook in the normal initramfs image
> at /boot/initramfs-linux.img . Thus if the user is unable to boot
> using /boot/initramfs-linux.img, he/she may be able to boot
> using /boot/initramfs-linux-fallback.img . Arch Linux and its
> derivatives use this kind of fallback initramfs setup. This patch also
> adds detection of this fallback initramfs image.
> I have attached the patch instead of sending this via git-send-mail,
> because 1) I haven't setup git-send-mail, and 2) Mail program seems to
> screw up the line indentation.
> With Best Regards,
> Keshav
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Grub-devel mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]