grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] fix crash in CLI on empty line with continuation


From: Andrey Borzenkov
Subject: [PATCH] fix crash in CLI on empty line with continuation
Date: Sun, 26 Jan 2014 01:41:13 +0400

GRUB would crash when getting the following (without quotes)

"\RETURN
 "RETURN

This results in empty args. OTOH having empty first argument is not really
a problem (it simply fails to find empty command name).

---
 grub-core/script/execute.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/script/execute.c b/grub-core/script/execute.c
index afd5513..6ef12a0 100644
--- a/grub-core/script/execute.c
+++ b/grub-core/script/execute.c
@@ -920,7 +920,7 @@ grub_script_execute_cmdline (struct grub_script_cmd *cmd)
   struct grub_script_argv argv = { 0, 0, 0 };
 
   /* Lookup the command.  */
-  if (grub_script_arglist_to_argv (cmdline->arglist, &argv) || ! argv.args[0])
+  if (grub_script_arglist_to_argv (cmdline->arglist, &argv) || ! argv.args)
     return grub_errno;
 
   invert = 0;
-- 
tg: (5ae584c..) u/zero_args_crash (depends on: master)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]