RE: [PATCH] Make CTRL and ALT keys work as expected on EFI systems (version 5).

[Mroczek, Joseph T]

> From: Peter Jones
> Sent: Tuesday, February 25, 2014 2:12 PM
> 
> This is version 4.
> 
> Changes from version 1:
> - handles SHIFT as a modifier
> - handles F11 and F12 keys
> - uses the handle provided by the system table to find our _EX protocol.
> 
> Changes from version 2:
> - eliminate duplicate keycode translation.
> 
> Changes from version 3:
> - Do not add the shift modifier for any ascii character between space
>   (0x20) and DEL (0x7f); the combination of the modifier and many of the
>   keys causes it not to be recognized at all.  Specifically, if we
>   include the modifier on any querty punctuation character, i.e.
>   anything the string "address@hidden&*()_+{}|:\"<>?" represents in C, it 
> stops
>   being recognized whatsoever.
> 
> Changes from version 4:
> - Always initialize term->data from locate protocol (i.e. make it
>   unconditional.)
> 

May I ask you to add one further extension. Add caps lock asserted to the 
conditions to bring up the menu. If this is not relevant to this patch or you 
wont add it, let me know and I will see if I can add on after the patch is 
accepted.

The reason for this is that there are some system that take as long as 15 
minutes to post. Trying to hit a specific key in a small window (even 30s) is 
difficult. Allowing caps lock to perform the same action as holding shift 
allows the user to essentially queue the request for the menu. This behavior is 
consistent with how syslinux/pxelinux works. 

Thank you for any consideration you can pay this request.

~joe