[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] Add new partition type API and convert GPT type checks.

From: Michael Marineau
Subject: Re: [RFC PATCH] Add new partition type API and convert GPT type checks.
Date: Mon, 22 Sep 2014 17:25:17 -0700

On Mon, Sep 22, 2014 at 4:04 PM, Vladimir 'φ-coder/phcoder' Serbinenko
<address@hidden> wrote:
> On 22.09.2014 20:59, Michael Marineau wrote:
>> This introduces a new type() function for partmaps modeled after the
>> label() and uuid() functions for filesystems. A likely future extension
>> will be support partition labels and uuids as well. This is in
>> preparation for adding more functionality like a search.part_type
>> command.
>> The msdos partition code is only partially converted for now, I'm not
>> sure about the preferred way to do this. Re-reading a msdos partition
>> table is not as easy as re-reading gpt is. One option would be to turn
>> 'msdostype' into a union or data pointer that partmap modules can stash
>> extra info in. That would also allow gpt to avoid re-reading. Being new
>> to grub, are there memory usage concerns I should be aware of here?
> Please provide a usecase. Every new feature needs a usecase. This patch
> increases core size and will not go in without a damn good usecase and
> justification why it needs to be done in core.

In reality I don't need to put anything into core, everything I need
can happily live in a brand new self-contained module. Since I need to
look up partitions by type it looked like a good opportunity to
consolidate the existing duplicated code for looking up GPT types into
a common API. If you have an alternate suggestion for cleaning up that
duplication I'm all ears, that's why I posted this early patch for
comments. :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]