[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix PXE transmit failure if P_UNKNOWN is not supported

From: Andrei Borzenkov
Subject: Re: [PATCH] fix PXE transmit failure if P_UNKNOWN is not supported
Date: Sat, 27 Sep 2014 10:26:32 +0400

В Sat, 26 Jul 2014 07:55:03 +0400
Andrey Borzenkov <address@hidden> пишет:

> В Fri, 25 Jul 2014 23:38:34 +0200
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> > On 25.07.2014 17:53, Andrey Borzenkov wrote:
> > > Some PXE stacks do not support P_UNKNOWN in UNDI TRANSMIT; nothing is
> > > sent at all. So strip Ethernet header for known frame types and let PXE
> > > stack add it.
> > > 
> > If I'm reading this patch correctly it discards several fields of the
> > packet and i.a. kills vlan fields.
> No, it does not. It discards Ethernet headers only when packet type is
> IP or ARP. VLAN packet will have different type and will be passed
> through as happens currently.

Ping? It fixes real problem in the wild and this exact approach is used
by other PXE stacks, so it is not as it is completely untested.

If this is not acceptable - any idea how this problem can be fixed
short of maintaining explicit black lists?

> >                                    Such low in the stack it should
> > replace the header only in the case of perfect match. It will be perfect
> > match in 99% of configs but we shouldn0t break configs on unaffected
> > machines.

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]