[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: How can I submit patch for bug #42944 ?

From: Rigoberto Corujo
Subject: Re: How can I submit patch for bug #42944 ?
Date: Mon, 13 Oct 2014 17:06:38 -0700

On Mon, 10/13/14, Rigoberto Corujo <address@hidden> wrote:

 Subject: Re: How can I submit patch for bug #42944 ?
 To: "Andrei Borzenkov" <address@hidden>, "The development of GNU GRUB" 
 Cc: "The development of GNU GRUB" <address@hidden>, address@hidden
 Date: Monday, October 13, 2014, 12:35 PM
 On Sun, 10/12/14, Andrei Borzenkov <address@hidden>
  Subject: Re: How
 can I submit patch for bug #42944 ?
 "Andrei Borzenkov" <address@hidden>
  Cc: "The development of GNU GRUB"
  Date: Sunday, October 12, 2014, 12:24 PM
  В Sat, 11 Oct 2014
  12:58:29 +0400
 Borzenkov <address@hidden>
 > В Sat, 11
  Oct 2014 10:44:20 +0200
  > Vladimir
 'φ-coder/phcoder' Serbinenko <address@hidden>
  > >
  On 10.10.2014
 23:23, Colin Watson wrote:
  > > >
 On Fri, Oct 10, 2014 at
  04:44:39PM +0000,
 Rigoberto Corujo wrote:
  > > >>
 I attached a patch to bug
  #42944 and would
 like to know how I would go about getting
 it committed to the source tree?
  > > > 
  > >
  I'd suggest attaching the patch to
 a mail here (not
  encased in a zip
  > > > file). 
 It's usually easier to get public review that way.
  > > > 
  > >
  don't like to use EFI timers if we
 can avoid them,
  they've been known
  > > to hang.
 is a patch to use pmtimer for calibration
  > What about systems
  without ACPI? Does it explicitly exclude
  OK, I stay
 corrected. Still,
  this patch adds over 1K
 to kernel on
 about 0.5K to common core.img with ext2:
  -rw-r--r-- 1 bor bor 26848 Oct
  12 20:09 /tmp/core.img-pmtimer
  -rw-r--r-- 1
  bor bor 26320
 Oct 12 18:50 /tmp/core.img-vanilla
 -rwxr-xr-x 1 bor bor 29224 Oct 12 20:08
  -rwxr-xr-x 1 bor
  28060 Oct 12 10:12
 think it's too much for
  something that
 so far is needed only on very
 platform. May be we could restrict it
 EFI only where size
  does not matter that
 Attached rebased
  patch (I briefly checked
 and it still boots on i386-pc
 apparently correctly handles timeouts, but
 I cannot check other
  -----Inline Attachment Follows-----
  Grub-devel mailing list
 Thank you
 very much for the patch.  I will test it on Hyper-V
 Generation 2 and other physical UEFI servers and let you
 know the results.  Regarding the concern that was expressed
 about SetTimer() sometimes hanging on UEFI systems, the
 following two files are already using SetTimer().
 Is it less likely that the
 hang occurs on those processors?
 Thank you,
 Rigoberto Corujo


I tried the pmtimer patch on Microsoft Hyper-V Generation 2, as well as a 
physical UEFI server, and it worked well.

Please let me know if this patch is going to be submitted.

Thank you,

Rigoberto Corujo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]