[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] grub-extras/lua: add fs label to grub.enum_device
Date: Fri, 27 Feb 2015 13:28:00 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0

On 27.02.2015 13:06, Andrei Borzenkov wrote:
On Fri, Feb 27, 2015 at 2:56 PM, Vladimir 'φ-coder/phcoder' Serbinenko
<address@hidden> wrote:
On 27.02.2015 12:47, Fajar A. Nugraha wrote:

+  lua_pushstring (state, label);

What happens if label is NULL?

In all cases if grub could mount filesystem it returns strdup(label).
Is it possible that mount fails without setting grub_errno? If yes, it
is probably a bug.

Nope. If filesystem has no label (rather than just empty label), it will have *label == NULL and return no error which is correct. Same for UUID. So unless lua_pushstring has special handling for NULL, this code needs to be fixed.
Grub-devel mailing list

Grub-devel mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]