[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 16/18] efi: create efi_exit_boot()

From: Jan Beulich
Subject: Re: [PATCH 16/18] efi: create efi_exit_boot()
Date: Mon, 02 Mar 2015 16:45:47 +0000

>>> On 30.01.15 at 18:54, <address@hidden> wrote:
> ..which gets memory map and calls ExitBootServices(). We need this
> to support multiboot2 protocol on EFI platforms.

Patches from 9 up to here all make sense on the basis that patch 18
does and assuming that you really need all this code moved out to
separate functions. How much different is efi_multiboot2() introduced
in #18 from what is left of efi_start() at this point? I.e. is splitting out
all of this code really needed?

If it is, please don't title all these patches "create ..." but "split out
..." or some such - you don't really create the code. Similarly the
second sentence above is too imprecise for my taste - "we want to
re-use this code to support ..." would seem more to the point.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]