[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] make grub-install on efi idempotent by omitting PE timestamp
From: |
Daniel Kahn Gillmor |
Subject: |
Re: [PATCH] make grub-install on efi idempotent by omitting PE timestamp |
Date: |
Fri, 20 Mar 2015 12:16:38 -0400 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) |
On Fri 2015-03-20 11:25:25 -0400, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> I've already detailed in another post in another post why embedding 0 is
> probably bad and that it's better to embed either 2015-01-01 00:00:00 or
> the date of last commit which can be put into modinfo.sh during compile
> time.
whoops, sorry! I missed that the first time through.
I just followed up on that thread with a patch using 2015-01-01
00:00:00.
I can work up another patch with modinfo.sh approach if you like, but i
think a stable/permanent timestamp is better. If i recompile grub with
a patch affecting some other piece of code (code that doesn't affect the
core image), and then i use the new grub to produce an image, i'd like
to be able to see that the resultant image is identical.
--dkg