[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] use stock embedded timestamp 2015-01-01T0000+0000
From: |
Daniel Kahn Gillmor |
Subject: |
Re: [PATCH] use stock embedded timestamp 2015-01-01T0000+0000 |
Date: |
Sat, 28 Mar 2015 12:04:33 -0400 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) |
On Fri 2015-03-27 08:27:42 -0400, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> @@ -1856,7 +1859,7 @@ grub_install_generate_image (const char *dir, const
>> char *prefix,
>> head->magic = image_target->bigendian ? grub_host_to_target16 (0x160)
>> : grub_host_to_target16 (0x166);
>> head->nsec = grub_host_to_target16 (1);
>> - head->time = grub_host_to_target32 (0);
>> + head->time = grub_host_to_target32 (STABLE_EMBEDDING_TIMESTAMP);
> I dropped this hunk as it's just changing one const to another.
>> head->opt = grub_host_to_target16 (0x38);
>> head->flags = image_target->bigendian
>> ? grub_host_to_target16 (0x207)
Sure, that's fine with me. I supplied it there so that we could say
"any grub image on any platform with an embedded timestamp will use the
same timestamp", but if you don't think that's a necessary or useful
statement to make, i have no interest in pushing it separately.
My main goal is image reproducibility, and the MIPS_ARC builds were
already reproducible. Thanks for adopting the fixed timestamp for the
other two platforms!
--dkg