Re: [PATCH 1/2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON`

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 28.05.2015 19:57, Paul Menzel wrote:
> Date: Thu, 28 May 2015 19:14:19 +0200
> 
> Instead of hard coding `2` and `4` use the macros defined already at the
> top of the file.
Splitting this and next patch makes absolutely no sense. If your changes
makes formatting of the changes line ugly, change formatting in the same
time unless it pollutes the view too much.
> ---
>  grub-core/disk/ahci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c
> index 7f75724..0825998 100644
> --- a/grub-core/disk/ahci.c
> +++ b/grub-core/disk/ahci.c
> @@ -552,7 +552,7 @@ grub_ahci_pciinit (grub_pci_device_t dev,
>                     adevs[i]->hba->ports[adevs[i]->port].sata_error);
>  
>       adevs[i]->hba->ports[adevs[i]->port].command
> -       = (adevs[i]->hba->ports[adevs[i]->port].command & 0x0fffffff) | (1 << 
> 28) | 2 | 4;
> +       = (adevs[i]->hba->ports[adevs[i]->port].command & 0x0fffffff) | (1 << 
> 28) | GRUB_AHCI_HBA_PORT_CMD_SPIN_UP | GRUB_AHCI_HBA_PORT_CMD_POWER_ON;
>  
>       /*  struct grub_disk_ata_pass_through_parms parms2;
>           grub_memset (&parms2, 0, sizeof (parms2));
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

signature.asc
Description: OpenPGP digital signature