[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] efinet: retransmit if our device is busy

From: Josef Bacik
Subject: Re: [PATCH] efinet: retransmit if our device is busy
Date: Fri, 11 Sep 2015 15:08:29 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 09/11/2015 12:49 PM, Andrei Borzenkov wrote:
31.08.2015 20:34, Josef Bacik пишет:
When I fixed the txbuf handling I ripped out the retransmission code
since it
was flooding our network when we had the buggy behavior.  Turns out
this was too
heavy handed as we can still have transient tx timeouts.  So instead
make sure
we retry our transmission once per timeout.  This way we can deal with
transmission problems without flooding the box.  This fixes an issue
we were
seeing in production.  Thanks,

You mean you get timeout in efi send_card_buffer, not higher level? That
sounds like something steals completion status. Could you send lsefi
after network interface was opened?

No i get a timeout at a higher level. We try to transmit, we never get the txbuf thing from getstatus, and we never redo the transmit. This just adds the retransmit back in. Thanks,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]