[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add check when store disk cache

From: Arch Stack
Subject: Re: Add check when store disk cache
Date: Fri, 18 Sep 2015 17:07:24 +0800

I want to use the part of the filesystem codes in GRUB to read different filesystems on Windows. I have almost completed it and I will release it in a few days.
But it crash sometimes because of the write of zero pointer.I debug it and find why it crashed.When I apply this patch, it won't crash because of this reason.

On Fri, Sep 18, 2015 at 12:03 PM, Andrei Borzenkov <address@hidden> wrote:
18.09.2015 03:15, Arch Stack пишет:
I found that the function *grub_disk_cache_store* didn't check for
*cache->lock* before free *cache->data*, and didn't set *cache->lock*
before memcpy something to *cache->data*. If multi thread handle with the
same cache at the same time, it will cause a fault.

Do you actually observe a problem or it is pure hypothesis? GRUB does not run multi-threaded and probably never will.

I have created a patch
for it.

Grub-devel mailing list

Grub-devel mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]