[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/4] * util/grub.d/ Add support of the XEN

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH v3 3/4] * util/grub.d/ Add support of the XEN boot on aarch64
Date: Thu, 29 Oct 2015 16:25:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0

> +if [ "x$machine" != xaarch64 ]; then
> +     multiboot_cmd="multiboot"
> +     module_linux_cmd="module"
> +     module_initrd_cmd="module --nounzip"
> +else
> +     multiboot_cmd="xen_hypervisor"
> +     module_linux_cmd="xen_linux"
> +     module_initrd_cmd="xen_initrd"
> +fi
> +
Please do not hardcode an assumption that grub-mkconfig is executed on
the same machine as GRUB is booted. I know that we have instances of
such assumption in some cases but we'd like to eliminate them. Alternatives:
- Check arch on boot time
- Check that new xen commands are supported (define a new feature)
Please add xen_* aliases on x86 as well

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]