[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] mkstandalone: add argument --fixed-time to override mtim

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH 1/3] mkstandalone: add argument --fixed-time to override mtime of files
Date: Fri, 4 Dec 2015 19:00:45 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0

On 04.12.2015 17:10, Alexander Couzens wrote:
> mkstandalone adds several files to an archive. Doing this it uses the
> mtime to give these files a timestamp.
> --fixed-time <TIME_EPOCH> overrides these timestamps with a given.
> Replacing all timestamps with a specific one is required
> to get reproducible builds. See source epoch specification of
Patch in general looks good. I'm unsure about which way the timestamp
should be passed and parsed. I see 3 solutions:
1) Argument and use some standard function to parse date supply argument
2) Essentially what you have done. It feels a bit ugly but not too much
3) Read directly from variable.
> +  {"fixed-time", 't', N_("TIMEEPOCH"), 0, N_("Use a fixed timestamp to 
> override mtime of all files. Time since epoch is used."), 2},
It's not worth spending a letter on this. Please keep only long version.

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]