Re: [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

[Fu Wei]

Hi Andrei

On 26 February 2016 at 13:24, Andrei Borzenkov <address@hidden> wrote:
>
>
> Отправлено с iPhone
>
>> 26 февр. 2016 г., в 7:48, Fu Wei <address@hidden> написал(а):
>>
>> Hi Andrei
>>
>>> On 26 February 2016 at 01:34, Andrei Borzenkov <address@hidden> wrote:
>>> 25.02.2016 09:39, address@hidden пишет:
>>>> From: Fu Wei <address@hidden>
>>>>
>>>> delete: xen_linux, xen_initrd, xen_xsm
>>>> add: xen_module
>>>>
>>>> This update bases on
>>>>    commit 0edd750e50698854068358ea53528100a9192902
>>>>    Author: Vladimir Serbinenko <address@hidden>
>>>>    Date:   Fri Jan 22 10:18:47 2016 +0100
>>>>
>>>>        xen_boot: Remove obsolete module type distinctions.
>>>>
>>>> Signed-off-by: Fu Wei <address@hidden>
>>>> ---
>>>> docs/grub.texi | 32 +++++++++-----------------------
>>>> 1 file changed, 9 insertions(+), 23 deletions(-)
>>>>
>>>> diff --git a/docs/grub.texi b/docs/grub.texi
>>>> index 82f6fa4..0f99c50 100644
>>>> --- a/docs/grub.texi
>>>> +++ b/docs/grub.texi
>>>> @@ -3861,9 +3861,7 @@ you forget a command, you can run the command 
>>>> @command{help}
>>>> * videoinfo::                   List available video modes
>>>> @comment * xen_*::              Xen boot commands
>>>> * xen_hypervisor::              Load xen hypervisor binary
>>>> -* xen_linux::                   Load dom0 kernel for xen hypervisor
>>>> -* xen_initrd::                  Load dom0 initrd for dom0 kernel
>>>> -* xen_xsm::                     Load xen security module for xen 
>>>> hypervisor
>>>> +* xen_module::                  Load xen modules for xen hypervisor
>>>> @end menu
>>>>
>>>>
>>>> @@ -5141,30 +5139,18 @@ verbatim as the @dfn{kernel command-line}. Any 
>>>> other binaries must be
>>>> reloaded after using this command.
>>>> @end deffn
>>>>
>>>> address@hidden xen_linux
>>>> address@hidden xen_linux
>>>> address@hidden xen_module
>>>> address@hidden xen_module
>>>>
>>>> address@hidden Command xen_linux file [arguments]
>>>> -Load a dom0 kernel image for xen hypervisor at the booting process of xen.
>>>> address@hidden Command xen_module [--nounzip] file [arguments]
>>>> +Load a module for xen hypervisor at the booting process of xen.
>>>> The rest of the line is passed verbatim as the module command line.
>>>> +Each module will be identified by the order in which the modules are 
>>>> added.
>>>> +The 1st module: dom0 kernel image
>>>> +The 2nd module: dom0 ramdisk
>>>> +All subsequent modules: UNKNOW
>>>> @end deffn
>>>
>>> Hmm ... from previous discussion I gathered that Xen can detect module
>>> type. What if there is no initrd for dom0? How can subsequent modules be
>>
>> Now , Xen detect module type by the order. (at least on ARM64).
>> I think i386 is using Multiboot(2) protocol, so maybe this order is
>> nothing to do with i386.
>>
>
> Then we have obvious problem with your XSM patch 
> (http://savannah.gnu.org/bugs/?43420) - XSM may land as the first module. 
> That's actually something to solve on Xen side I think. It's just that so far 
> we had just kernel and initrd, so that was non issue.

Oh, did you mean Wei Liu's patch?

I guess XSM may land as the third module (or the module after linux
kernel, if you don't have initrd)

Yes, agree. (That's actually something to solve on Xen side)

I guess xen can get xsm from a special initrd. so for now there is not
big problem on xsm.

Please correct me if I misunderstand something. :-)

Thanks!

Back to this patch, is that OK for you, or any suggestion?  Thanks !

>
>
>> so maybe we can say:
>> -----------------------------
>> On ARM64, each module will be identified by the order in which the
>> modules are added.
>> The 1st module: dom0 kernel image
>> The 2nd module: dom0 ramdisk (optional)
>> All subsequent modules: UNKNOWN
>>
>> On i386,  the modules will be identified by Multiboot(2) protocol.
>> -----------------------------
>>
>> Is that better?  please correct me if I miss something.
>>
>>> loaded then?
>>>
>>>> address@hidden xen_initrd
>>>> address@hidden xen_initrd
>>>> -
>>>> address@hidden Command xen_initrd file
>>>> -Load a initrd image for dom0 kernel at the booting process of xen.
>>>> address@hidden deffn
>>>> -
>>>> address@hidden xen_xsm
>>>> address@hidden xen_xsm
>>>> -
>>>> address@hidden Command xen_xsm file
>>>> -Load a xen security module for xen hypervisor at the booting process of 
>>>> xen.
>>>> -See @uref{http://wiki.xen.org/wiki/XSM} for more detail.
>>>> address@hidden deffn
>>>> -
>>>> -
>>>> @node Networking commands
>>>> @section The list of networking commands
>>
>>
>>
>> --
>> Best regards,
>>
>> Fu Wei
>> Software Engineer
>> Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
>> Ph: +86 21 61221326(direct)
>> Ph: +86 186 2020 4684 (mobile)
>> Room 1512, Regus One Corporate Avenue,Level 15,
>> One Corporate Avenue,222 Hubin Road,Huangpu District,
>> Shanghai,China 200021



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021