[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2 1/4] ofnet: add error check for grub_netbuff_reserve
From: |
Andrei Borzenkov |
Subject: |
Re: [PATCH V2 1/4] ofnet: add error check for grub_netbuff_reserve |
Date: |
Sat, 10 Dec 2016 21:08:38 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
02.12.2016 18:10, Stanislav Kholmanskikh пишет:
> Signed-off-by: Stanislav Kholmanskikh <address@hidden>
> ---
> grub-core/net/drivers/ieee1275/ofnet.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/grub-core/net/drivers/ieee1275/ofnet.c
> b/grub-core/net/drivers/ieee1275/ofnet.c
> index 6bd3b92..8332d34 100644
> --- a/grub-core/net/drivers/ieee1275/ofnet.c
> +++ b/grub-core/net/drivers/ieee1275/ofnet.c
> @@ -90,7 +90,11 @@ get_card_packet (struct grub_net_card *dev)
> return NULL;
> /* Reserve 2 bytes so that 2 + 14/18 bytes of ethernet header is divisible
> by 4. So that IP header is aligned on 4 bytes. */
> - grub_netbuff_reserve (nb, 2);
> + if (grub_netbuff_reserve (nb, 2))
> + {
> + grub_netbuff_free (nb);
> + return NULL;
> + }
>
> start_time = grub_get_time_ms ();
> do
>
We already account for this reserve when we allocate netbuf. So this is
redundant. May be short comment before grub_netbuf_alloc to explain how
we get at final size.