[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] include sys/sysmacros.h for getting major() definition
From: |
Khem Raj |
Subject: |
Re: [PATCH] include sys/sysmacros.h for getting major() definition |
Date: |
Tue, 20 Dec 2016 12:13:32 -0800 |
> On Dec 19, 2016, at 8:39 AM, Andrei Borzenkov <address@hidden> wrote:
>
> 19.12.2016 03:12, Khem Raj пишет:
>>
>>> On Dec 18, 2016, at 12:57 PM, Andrei Borzenkov <address@hidden> wrote:
>>>
>>> 18.12.2016 23:44, Khem Raj пишет:
>>>>
>>>>> On Dec 18, 2016, at 12:41 PM, Andrei Borzenkov <address@hidden> wrote:
>>>>>
>>>>> 18.12.2016 23:38, Khem Raj пишет:
>>>>>>
>>>>>> Thanks for your review. On further investigation the issue seems to be
>>>>>> autoconf related
>>>>>> with commit
>>>>>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=7a5b301e3adb8e054288518a325135a1883c1c6c
>>>>>>
>>>>>> <http://git.savannah.gnu.org/cgit/grub.git/commit/?id=7a5b301e3adb8e054288518a325135a1883c1c6c>
>>>>>>
>>>>>> grub is using AC_HEADER_MAJOR to find this out, however the check is
>>>>>> failing
>>>>>
>>>>> Please attach config.log.
>>>>>
>>>>>
>>>
>>> This should be fixed in autoconf commit
>>> e17a30e987d7ee695fb4294a82d987ec3dc9b974 which will be in 2.70. I do not
>>> know what plans there are to release it. Can you test if using current
>>> autoconf GIT fixes this? You will need to rebuild configure using
>>> updated autoconf.
>>
>> I backported that patch into 2.69 and this fixed the issue. This patch can
>> be dropped since its not needed with 2.70+
>> and with the above back port for older autoconf.
>>
>
> We cannot really force everyone to use bleeding edge that is not even
> released. Could you please test attached patch with plain autoconf 2.69
> or below?
> <glibc-2.25-header_major.patch>
This seemed to work in my environment.
- [PATCH] include sys/sysmacros.h for getting major() definition, Khem Raj, 2016/12/18
- Re: [PATCH] include sys/sysmacros.h for getting major() definition, Andrei Borzenkov, 2016/12/18
- Re: [PATCH] include sys/sysmacros.h for getting major() definition, Khem Raj, 2016/12/18
- Re: [PATCH] include sys/sysmacros.h for getting major() definition, Andrei Borzenkov, 2016/12/18
- Re: [PATCH] include sys/sysmacros.h for getting major() definition, Khem Raj, 2016/12/18
- Re: [PATCH] include sys/sysmacros.h for getting major() definition, Andrei Borzenkov, 2016/12/18
- Re: [PATCH] include sys/sysmacros.h for getting major() definition, Khem Raj, 2016/12/18
- Re: [PATCH] include sys/sysmacros.h for getting major() definition, Andrei Borzenkov, 2016/12/19
- Re: [PATCH] include sys/sysmacros.h for getting major() definition,
Khem Raj <=
- Re: [PATCH] include sys/sysmacros.h for getting major() definition, Andrei Borzenkov, 2016/12/22