[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolo

From: Matthew Garrett
Subject: Re: [PATCH 4/4] Allow protocol to be separated from host with a semicolon
Date: Tue, 24 Jan 2017 20:06:20 -0800

On Tue, Jan 24, 2017 at 7:48 PM, Andrei Borzenkov <address@hidden> wrote:
> 24.01.2017 23:50, Matthew Garrett пишет:
>> On Mon, Jan 23, 2017 at 8:02 PM, Andrei Borzenkov <address@hidden> wrote:
>>> 24.01.2017 03:36, Matthew Garrett пишет:
>>>> Some DHCP servers (such as dnsmasq) tokenise parameters with commas, making
>>>> it impossible to pass boot files with commas in them. Allow using a
>>> grub_net_open() operates on devices, not files. Please give more details
>>> about your problem.
>> The DHCP server will return a string in the boot_file field. If you
>> want to indicate that this file should be obtained over http, the
>> easiest way to handle this is to provide a boot file in the form
>> (http,host)filename. Unfortunately dnsmasq uses commas to tokenise its
>> configuration parameters and there appears to be no way to override
>> that, which makes it impossible to provide a boot file in this form.
>> Allowing the use of an alternative character avoids this problem.
> This won't work because (http,host) will never be interpreted as device
> in current code so you need to support this first before this patch can
> even be considered. Also I am not convinced that arbitrary changing
> syntax is good idea.

I don't understand - grub_net_open_real() already handles this case:

      const char *comma;
      comma = grub_strchr (name, ',');
      if (comma)
          protnamelen = comma - name;
          server = comma + 1;
          protname = name;
          protnamelen = grub_strlen (name);
          server = grub_net_default_server;
          protname = name;

> You already can set $prefix when generating image. Why is it not enough?

Because we ship prebuilt images but don't know what IP addresses users
will be using for their deployment servers.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]