Re: [GRUB PARTUUID PATCH V3 0/5] Add PARTUUID detection support

[Nick Vinson]

I would like to remind grub-devel of this patch set.  Since the last
time I submitted this, Flex-2.6.4 has been released, so Part 1 of this
patch set can now be dropped.  Part 5 is optional and can be removed if
the development team does not approve of its changes.

Finally, this is the version that included Steve Kenton's work as
requested by Andrei Borzenkov.  Steve Kenton's work is Part #4.

If necessary, I can resubmit the patch set with parts 1 and 4 (and 5)
removed.

Please let me know how you would like me to proceed.

Thanks,
Nicholas Vinson

On 02/26/2017 04:20 PM, Nicholas Vinson wrote:
> Changes from Patch v2:
>     - Added flex-2.6.3 compatibility patch
> 
>     - Fixed a GPT partition read error
> 
>     - Added Steve Kenton's patch
> 
>     - Changed struct grub_part_gpt_type name to struct
>       grub_part_gpt_part_guid
> 
>     - Changed grub_part_gpt_type_t typedef name to grub_part_gpt_guid_t
> 
>     - Added sprint_gpt_guid to Steve Kenton's patch
> 
>     - Updated v1 and Steve Kenton's patch to use similar methods when
>       reading partition GUIDs.
> 
> Changes from Patch v1:
>     - Added GRUB_ENABLE_LINUX_PARTUUID variable description to grub.texi
> 
>     - Removed added gpt_part_guid copy logic from
>       grub_gpt_partition_map_iterate()
> 
>     - Removed added NT disk signature copy logic from
>       grub_partition_msdos_iterate()
> 
>     - Removed modifications to partition number increment logic
> 
>     - Removed added guid union definition.
> 
>     - Added GRUB_ENABLE_LINUX_PARTUUID to grub-mkconfig.in export list
> 
>     - Moved PRINT_GPT_PARTTYPE printing logic to print_gpt_guid()
>       function in grub-probe.c
> 
>     - Updated PRINT_GPT_PARTTYPE case to call print_gpt_guid() function
>       in grub-probe.c.
> 
>     - Created probe_partuuid() function in grub-probe.c
> 
>     - Updated print == PRINT_PARTUUID check logic in probe() to call
>       probe_partuuid().
> 
>     - Updated UUID logic in 10_linux.in to enable root=PARTUUID feature
>       only if GRUB_DISABLE_LINUX_UUID is not set to true,
>       and GRUB_DEVICE_PARTUUID is not empty, GRUB_ENABLE_LINUX_PARTUUID
>       is set to true.
> 
> Hello,
> 
> This is a request to add PARTUUID detection support grub-probe for MBR
> and GPT partition schemes.  The Linux kernel supports mounting the root
> filesystem by Linux device name or by the Partition [GU]UID.  GRUB's
> mkconfig, however, currently only supports specifying the rootfs in the
> kernel command-line by Linux device name unless an initramfs is also
> present.  When an initramfs is present GRUB's mkconfig will set the
> kernel's root parameter value to either the Linux device name or to the
> filesystem [GU]UID.
> 
> Therefore, the only way to protect a Linux system from failing to boot
> when its Linux storage device names change is to either manually edit
> grub.cfg or /etc/default/grub and append root=PARTUUID=xxx to the
> command-line or create an initramfs that understands how to mount
> devices by filesystem [G]UID and let grub-mkconfig pass the filesystem
> [GU]UID to the initramfs.
> 
> The goal of this patch set is to enable root=PARTUUID=xxx support in
> grub-mkconfig, so that users don't have to manually edit
> /etc/default/grub or grub.cfg, or create an initramfs for the sole
> purpose of having a robust bootloader configuration for Linux.
> 
> Thanks,
> Nicholas Vinson
> 
> Nicholas Vinson (4):
>   Fix flex-2.6.3 incompatbility issue
>   Add PARTUUID detection support to grub-probe
>   Update grub script template files
>   Harmonize patches
> 
> Steve Kenton (1):
>   Support both EFI and NT Disk Signature for passing to kernel as
>     root=PARTUUID=$val
> 
>  docs/grub.texi               | 13 +++++++
>  grub-core/commands/probe.c   | 78 ++++++++++++++++++++++++++++++++++++++++++
>  grub-core/disk/ldm.c         |  2 +-
>  grub-core/partmap/gpt.c      |  4 +--
>  grub-core/script/yylex.l     | 22 +++++++++---
>  include/grub/gpt_partition.h |  8 ++---
>  util/grub-install.c          |  2 +-
>  util/grub-mkconfig.in        |  3 ++
>  util/grub-probe.c            | 81 
> ++++++++++++++++++++++++++++++++++++--------
>  util/grub.d/10_linux.in      | 13 +++++--
>  10 files changed, 197 insertions(+), 29 deletions(-)
>

signature.asc
Description: OpenPGP digital signature