[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] i386/x86_64: make linux header definitions arch-specific

From: Daniel Kiper
Subject: Re: [PATCH 1/4] i386/x86_64: make linux header definitions arch-specific
Date: Wed, 13 Sep 2017 05:45:58 +0200
User-agent: Mutt/1.3.28i

Hi Leif,

Sorry for late reply but I am traveling. I should be
more responsive starting from next week.

On Tue, Sep 05, 2017 at 09:41:11PM +0100, Leif Lindholm wrote:
> and linux_kernel_header -> linux_i386_kernel_header.

I think that this begs for 2 separate patches.

> Also change the include guard on grub/i386/linux.h to prevent clashes
> when including multiple linux.h headers (like in commands/file.c).

Third patch.

> Signed-off-by: Leif Lindholm <address@hidden>
> ---
> OK, so one question here: in order to follow existing style, I have kept
> to the existing linux_ format. Is that the appropriate prefix, or should
> this be grub_linux_ like I originally used in the ARM series?

I prefer linux_.

> Regardless, I intend to align the ARM patches to whatever format ends up
> being used for this patch.

Please do.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]