[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] sparc64: fix OF path names for sun4v systems

From: John Paul Adrian Glaubitz
Subject: Re: [PATCH] sparc64: fix OF path names for sun4v systems
Date: Mon, 18 Dec 2017 23:58:02 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 12/18/2017 10:30 PM, Eric Snowberg wrote:
>> This is not good. It will not work if you cross compile.
> What error do you see on a cross compile?  I see __sparc__ used throughout 
> the code.

I agree. This should not cause any issues when cross-compiling, the 
targeting __$ARCH__ always comes with the same compiler macros and definitions
as the native compiler.

>>> +static void
>>> +check_hba_identifiers (const char *sysfs_path, int *vendor, int *device_id)
>>> +{
>>> +  char *ed = strstr (sysfs_path, "host");
>>> +  size_t path_size;
>>> +  char *p = NULL, *path = NULL;
>> I think that you do not need to initialize *p here.
> I’ll remove the initialization. 

I think that change was suggested by me as the code wouldn't build with
-Werror without the initialization. -Werror is the default when building
GRUB, if I remember correctly.


 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - address@hidden
`. `'   Freie Universitaet Berlin - address@hidden
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

reply via email to

[Prev in Thread] Current Thread [Next in Thread]