[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libgcrypt: Import replacement CRC operations

From: Daniel Kiper
Subject: Re: [PATCH] libgcrypt: Import replacement CRC operations
Date: Tue, 20 Feb 2018 18:20:17 +0100
User-agent: Mutt/1.3.28i

On Sun, Feb 11, 2018 at 12:18:12AM +0000, Colin Watson wrote:
> The CRC implementation imported from libgcrypt 1.5.3 is arguably
> non-free, due to being encumbered by the restrictive Internet Society
> licence on RFCs (see e.g.
> Fortunately, libgcrypt has since replaced it with a version that is both
> reportedly better-optimised and doesn't suffer from this encumbrance.
> The ideal solution would be to update to a new version of libgcrypt, and
> I spent some time trying to do that.  However, util/
> requires complex modifications to cope with the new version, and I
> stalled part-way through; furthermore, GRUB's libgcrypt tree already
> contains some backports of upstream changes.  Rather than allowing the
> perfect to be the enemy of the good, I think it's best to backport this
> single change to at least sort out the licensing situation.  Doing so
> won't make things any harder for a future wholesale upgrade.
> This commit is mostly a straightforward backport of
> but I also imported bufhelp.h from libgcrypt 1.7.0 (newer versions
> required further changes elsewhere).
> I've tested that "hashsum -h crc32" still produces correct output for a
> variety of files on both i386-pc and x86_64-emu targets.
> Signed-off-by: Colin Watson <address@hidden>

Reviewed-by: Daniel Kiper <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]