[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug#891773: [PATCH] ieee1275: Fix crash in of_path_of_nvme when of_p

From: John Paul Adrian Glaubitz
Subject: Re: Bug#891773: [PATCH] ieee1275: Fix crash in of_path_of_nvme when of_path is empty
Date: Thu, 1 Mar 2018 18:13:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/01/2018 05:59 PM, James Clarke wrote:
Whitespace issues aside, should it not be returning NULL if of_path is
NULL, like the other users of find_obppath, such as of_path_of_scsi?

Hmm. Good point.

This should restore the behaviour from before of_path_of_nvme was added,
as grub_util_devname_to_ofpath would have previously returned NULL due
to the unknown type?

Right. I'll wait for some comments from Daniel and Eric first though.


 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - address@hidden
`. `'   Freie Universitaet Berlin - address@hidden
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

reply via email to

[Prev in Thread] Current Thread [Next in Thread]