[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] Cryptomount support LUKS detached header

From: Paul Menzel
Subject: Re: [PATCH 1/7] Cryptomount support LUKS detached header
Date: Wed, 21 Mar 2018 08:23:57 +0100

Dear John,

Am Mittwoch, den 14.03.2018, 19:00 +0000 schrieb John Lane:
> On 14/03/18 13:05, Daniel Kiper wrote:
> > On Wed, Mar 14, 2018 at 09:44:58AM +0000, John Lane wrote:
> > > From: John Lane <address@hidden>
> > 
> > I have just skimmed through the series. First of all, most if not
> > all patches beg for full blown commit messages. Just vague statements
> > in the subject are insufficient for me. And please add patch 0 which
> > introduces the series. git send-email --compose is your friend.
> Sorry Daniel, this isn't something I do that often - submitting patches
> to ML. Do you want me to resubmit them again, or is the below ok for you ?


Thank you very much for submitting these patches for review. Judging
from the other comments, it looks like, you are going to send an
updated series anyway, so I guess, you can wait until then, though
expect another round then.

I do not know, how well you are versed with git, but it’d be great, if
you added your messages below as “real” commit messages. `git rebase -i
origin/master` should do that for you. Just replace *pick* by *r*, for
*r*eword, and add the commit messages there.

So, as testing the review changes will take some time, I suggest you
try to resend the patch series as soon as possible to get as much
reviews as possible, so you can test everything, when you get to it.



Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]