[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RFC] Proposition of a --auto-nvram option for grub-install

From: Daniel Kiper
Subject: Re: [PATCH RFC] Proposition of a --auto-nvram option for grub-install
Date: Mon, 23 Apr 2018 14:02:22 +0200
User-agent: Mutt/1.3.28i

Hey Lukasz,

On Thu, Apr 19, 2018 at 11:29:28AM +0200, Lukasz Zemczak wrote:
> Hey Daniel!
> Thank you for your feedback! I can drop the warning message, sure, I
> added it only for verbosity anyway so there's no real reason for
> keeping it around.


> As for your second comment: generally this is what I want to achieve
> by checking the return value of the efibootmgr command. Whenever
> efibootmgr exits with an error code of 2 this basically means "EFI
> variables are not supported on this system." - i.e. that the system
> we're running on has no NVRAM (at least in efibootmgr's mind). In all
> other cases, if there is any other error returned by efiboomgr, fail
> the grub_install_register_efi() as we did before. Therefore if
> something fails on a platform with NVRAM, we fail hard as previously.

What will happen if efibootmgr is not installed? I think that grub-install
should do nothing silently if --auto-nvram is passed. And should not you
check if /sys/firmware/efi exits instead of blindly trying efibootmgr?
Additionally, please do not forget to update docs: man, grub.texi, --help
for grub-install, etc.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]