[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mbi: use per segment a separate relocator chunk

From: Alexander Boettcher
Subject: Re: [PATCH] mbi: use per segment a separate relocator chunk
Date: Tue, 5 Jun 2018 21:59:39 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 15.05.2018 15:42, Daniel Kiper wrote:
> On Mon, May 14, 2018 at 09:02:00PM +0200, Alexander Boettcher wrote:
>>    grub_relocator_chunk_t ch;
>> -  grub_uint32_t load_offset, load_size;
>> +  grub_uint32_t load_offset = 0, load_size;
>>    int i;
>> -  void *source;
>> +  void *source = NULL;
> It seems to me that this change is not needed.
> I am thinking about "void *source = NULL;".

The compiler complains if I remove the NULL assignment with:

 error: ‘source’ may be used uninitialized in this function
             grub_memset ((grub_uint8_t *) source + load_offset +
phdr(i)->p_filesz, 0,

I try to incorporate your further comments and re-send the patch.

Alexander Boettcher
Genode Labs -

Genode Labs GmbH - Amtsgericht Dresden - HRB 28424 - Sitz Dresden
Geschäftsführer: Dr.-Ing. Norman Feske, Christian Helmuth

reply via email to

[Prev in Thread] Current Thread [Next in Thread]