[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] efi/fdt: set #address-cells/#size-cells on empty tree

From: Daniel Kiper
Subject: Re: [PATCH 0/2] efi/fdt: set #address-cells/#size-cells on empty tree
Date: Thu, 14 Jun 2018 15:38:13 +0200
User-agent: Mutt/1.3.28i

On Mon, Jun 11, 2018 at 05:24:57PM +0100, Leif Lindholm wrote:
> Set #address-cells and #size-cells properties (to 2) for ARM*/UEFI
> systems when creating an empty DT at boot time. This resolves an issue
> seen in the wild with kexec on certain 64-bit ARM systems.
> First part is moving out the prop_entry_size macro from lib/fdt.c
> and make it available in <grub/fdt.h> (with the required name
> change).
> Second part is adding the two properties to the empty tree.

In general LGTM. Though I would prefer "?" instead of "if" in patch #2.
Or at least drop curly braces. Anyway, if you are OK with proposed
changes I can incorporate them before push.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]