[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] ieee1275: obdisk driver

From: John Paul Adrian Glaubitz
Subject: Re: [PATCH v2] ieee1275: obdisk driver
Date: Fri, 15 Jun 2018 14:05:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/15/2018 02:02 PM, Daniel Kiper wrote:
>> +static int disks_enumerated = 0;
>> +static struct disk_dev *disk_devs = NULL;
>> +static struct parent_dev *parent_devs = NULL;
> I would drop all these 0/NULL initializations.
> Compiler will do work for you. I asked about
> that in earlier comments.

Not sure about that though. I seem to remember that newer gcc versions
were quite nitpicky about that when building with -Werror and I had
to add a NULL initialization to get it to build.


 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - address@hidden
`. `'   Freie Universitaet Berlin - address@hidden
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

reply via email to

[Prev in Thread] Current Thread [Next in Thread]