[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] ieee1275: obdisk driver

From: Daniel Kiper
Subject: Re: [PATCH v2] ieee1275: obdisk driver
Date: Fri, 15 Jun 2018 14:14:36 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Jun 15, 2018 at 02:05:32PM +0200, John Paul Adrian Glaubitz wrote:
> On 06/15/2018 02:02 PM, Daniel Kiper wrote:
> >> +static int disks_enumerated = 0;
> >> +static struct disk_dev *disk_devs = NULL;
> >> +static struct parent_dev *parent_devs = NULL;
> >
> > I would drop all these 0/NULL initializations.
> > Compiler will do work for you. I asked about
> > that in earlier comments.
> Not sure about that though. I seem to remember that newer gcc versions
> were quite nitpicky about that when building with -Werror and I had
> to add a NULL initialization to get it to build.

If this is true I am not going to insist. Sadly I have asked about
that in the earlier comments and I have not seen any reply WRT nor
changes to the code. So, that is why I am repeating my question.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]