[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

From: Paul Menzel
Subject: Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs
Date: Wed, 10 Oct 2018 09:34:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Dear Nick,

Thank you very much for your patches.

Am 10.10.2018 um 01:21 schrieb Nick Terrell:

This patch set imports the upstream zstd library, adds zstd support to the
btrfs module, and adds a test case. I've also tested the patch set by storing
my boot partition in btrfs with and without zstd compression and rebooting.

The fist patch imports the files needed to support zstd decompression from
zstd-1.3.6 as-is. It is a very large patch. In case it doesn't make it,
I've included the commit hash and the script I used to download the files.

Upstream zstd commit hash: 4fa456d7f12f8b27bd3b2f5dfd4f46898cb31c24
Upstream zstd commit name: Merge pull request #1354 from facebook/dev

#!/bin/sh -e

curl -L -O
curl -L -O
sha256sum --check zstd-1.3.6.tar.gz.sha256
tar xzf zstd-1.3.6.tar.gz

rm -rf $DST_LIB
mkdir -p $DST_LIB
cp $SRC_LIB/zstd.h $DST_LIB/
cp $SRC_LIB/common/*.[hc] $DST_LIB/
cp $SRC_LIB/decompress/*.[hc] $DST_LIB/
rm $DST_LIB/{pool.[hc],threading.[hc]}
rm -rf zstd-1.3.6*

Sorry for being ignorant, but you explain, why the library needs to be imported and it is not enough to use that library as an external dependency?

Importing the library means, it has to be maintained in the GRUB repository, which will result in some maintenance burden.

Kind regards,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]