[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not

From: Daniel Kiper
Subject: Re: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.
Date: Wed, 17 Oct 2018 15:51:28 +0200
User-agent: Mutt/1.3.28i

On Thu, Oct 11, 2018 at 08:50:58PM +0200, Goffredo Baroncelli wrote:
> From: Goffredo Baroncelli <address@hidden>
> Currently read from missing device triggers rescan. However, it is never
> recorded that the device is missing. So, each read of a missing device
> triggers rescan again and again. This behavior causes a lot of unneeded
> rescans leading to huge slowdowns.
> This patch fixes above mentioned issue. Information about missing devices
> is stored in the data->devices_attached[] array as NULL value in dev
> member. Rescan is triggered only if no information is found for a given
> device. This means that only first time read triggers rescan.
> The patch drops premature return. This way data->devices_attached[] is
> filled even when a given device is missing.
> Signed-off-by: Goffredo Baroncelli <address@hidden>

I changed commit message, so, you should add
  Signed-off-by: Daniel Kiper <address@hidden>

I simply forgot to tell you about that. Sorry.

And below you can add
  Reviewed-by: Daniel Kiper <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]