[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] mkimage: Simplify header size logic

From: Daniel Kiper
Subject: Re: [PATCH v2 1/2] mkimage: Simplify header size logic
Date: Mon, 14 Jan 2019 14:29:11 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Sun, Dec 23, 2018 at 03:52:06AM +0100, Alexander Graf wrote:
> For EFI images, we always have the following layout:
>   [PE header]
>   [padding]
>   [first section (which also is the entry point)]
> Currently there are 2 places where we define how big header+padding are:
> in the .vaddr_offset member of our target image definition struct as well
> as in code in grub_install_generate_image().
> Remove the latter, so that we only have a single place to modify if we
> need to change the padding.
> Signed-off-by: Alexander Graf <address@hidden>

Reviewed-by: Daniel Kiper <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]