[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bootp: add native DHCPv4 support

From: Andre Przywara
Subject: Re: [PATCH] bootp: add native DHCPv4 support
Date: Mon, 11 Feb 2019 18:10:47 +0000

On Thu, 24 Jan 2019 15:13:19 +0100
Daniel Kiper <address@hidden> wrote:

Hi Daniel,

> On Mon, Jan 21, 2019 at 02:10:48PM +0000, Andre Przywara wrote:
> > On Mon, 21 Jan 2019 13:02:08 +0100
> > Daniel Kiper <address@hidden> wrote:


> > > Is it possible to split this patch to smaller pieces?  
> >
> > Possible: yes, though I am not sure I understand enough of it and grub
> > to do it properly. Will try my best, though, as soon as I find some
> > spare cycles to understand the patch a bit better.  
> Is it matter of days, weeks or months?

Apparently a matter of 18 days ;-)

So I read the Wikipedia pages for DHCP and BOOTP, skimmed over the various RFCs 
and wrapped my head around the high level functionality of the grub network 
stack. After starring a while at Andrei's patch I think I figured what he did.
So I managed to break it down into a series of refactoring patches, with some 
patches on top to add the actual DHCP functionality.
I will clean that up and try to test it as far as possible.

> > The rest of the comments make sense, I will address them eventually,
> > unless someone (Andrei?) screams...  
> Thanks a lot!
> I am looking forward for next version of this patch.

Prepare for a series of 9 patches (at the moment) later this week. ;-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]