[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/1] Upgrade Gnulib; switch to bootstrap tool

From: Daniel Kiper
Subject: Re: [PATCH v2 1/1] Upgrade Gnulib; switch to bootstrap tool
Date: Fri, 1 Mar 2019 13:07:26 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Wed, Feb 27, 2019 at 10:03:55AM +0000, Colin Watson wrote:
> Upgrade Gnulib files to 20190105.
> It's much easier to maintain GRUB's use of portability support files
> from Gnulib when the process is automatic and driven by a single
> configuration file, rather than by maintainers occasionally running
> gnulib-tool and committing the result.  Removing these
> automatically-copied files from revision control also removes the
> temptation to hack the output in ways that are difficult for future
> maintainers to follow.  Gnulib includes a "bootstrap" program which is
> designed for this.
> The canonical way to bootstrap GRUB from revision control is now
> "./bootstrap", but "./" is still useful if you just want to
> generate the GRUB-specific parts of the build system.
> GRUB now requires Autoconf >= 2.63 and Automake >= 1.11, in line with
> Gnulib.
> Gnulib source code is now placed in grub-core/lib/gnulib/ (which should
> not be edited directly), and GRUB's patches are in
> grub-core/lib/gnulib-patches/.  I've added a few notes to the developer
> manual on how to maintain this.
> Signed-off-by: Colin Watson <address@hidden>

Reviewed-by: Daniel Kiper <address@hidden>

But you forgot to update Autoconf and Automake required version in INSTALL
file. If it is not a problem for you I will update it before pushing
this patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]