Re: [PATCH] sparc64: add bios boot partition support

[Daniel Kiper]

On Wed, Mar 06, 2019 at 08:56:53AM -0700, Eric Snowberg wrote:
> > On Mar 6, 2019, at 3:52 AM, Daniel Kiper <address@hidden> wrote:
> > On Mon, Mar 04, 2019 at 05:34:01PM -0800, Eric Snowberg wrote:
> >> Add BIOS Boot Partition support for sparc64 platforms.  This will work a
> >> little different than x86.  With GPT, both the OBP "load" and "boot" 
> >> commands
> >> are partition aware and neither command can see the partition table.  
> >> Therefore
> >> the entire boot-loader is stored within the BIOS Boot Partition and nothing
> >> is stored within the bootstrap code area of MBR.
> >>
> >> To use it, the end user will issue the boot command with the path pointing 
> >> to
> >> the BIOS Boot Partition.
> >>
> >> For example with the disk below:
> >>
> >> Model: Unknown (unknown)
> >> Disk /dev/nvme1n1: 1600GB
> >> Sector size (logical/physical): 512B/512B
> >> Partition Table: gpt
> >>
> >> Number  Start   End     Size    File system  Name  Flags
> >> 1      1049kB  1075MB  1074MB   ext3
> >> 2      1075MB  1076MB  1049kB                     bios_grub
> >> 3      1076MB  1600GB  1599GB                     lvm
> >>
> >> To boot grub2 from OBP, you would use:
> >>
> >> boot 
> >> /address@hidden/address@hidden/address@hidden/address@hidden/address@hidden/address@hidden:b
> >>
> >> Signed-off-by: Eric Snowberg <address@hidden>
> >
> > Have you tested this patch on the other platforms?
> > If yes then I am OK with the patch.
>
> It has been tested on x86 and SPARC.  It is my understanding that x86
> and SPARC are the only two platforms that can use this file.  If that
> is not correct, let me know.

Great! So, Reviewed-by: Daniel Kiper <address@hidden>

Again, thank you for doing the SPARC work!

Daniel