[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] Add new MSR modules (rdmsr/wrmsr)

From: Jesús Diéguez Fernández
Subject: Re: [PATCH v2 2/2] Add new MSR modules (rdmsr/wrmsr)
Date: Thu, 7 Mar 2019 22:28:06 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

El 7/3/19 a las 20:58, Daniel Kiper escribió:
> On Thu, Mar 07, 2019 at 07:05:20PM +0100, Jesús Diéguez Fernández wrote:
> [...]


>> - And from a practical point of view, in case that I need to setup a
>> custom handler for this, is it mandatory to ship the patch with it or
>> could it be added later (maybe adding a TODO now)?
> I can accept this patch series without #GP handler if:
>   - you add warning to the GRUB doc that #GP for rdmsr/wrmsr are not
>     handled and system reboots; so, potential users have to be careful
>     using these modules,
>   - you add TODO notice to the code saying that generic #GP handling
>     should be added to the GRUB code,

That's what I had in mind.

>   - you promise me that at some point, let's say after GRUB release,
>     you will try to implement generic #GP handler.
> > Is this acceptable for you?
> Daniel

I think that having a generic #GP handler is a nice improvement.
As I said before, I don't know exactly the size of the rabbit hole I'm
entering, so I can't guarantee a delivery date, but I do guarantee that
I'll do my best.

GRUB is becoming very interesting to me, if you don't mind having a
newbie around here, maybe making one question or two sometimes, then we
have a deal. :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]