Re: [PATCH v2 2/2] Add new MSR modules (rdmsr/wrmsr)

[Daniel Kiper]

On Thu, Mar 07, 2019 at 10:28:06PM +0100, Jesús Diéguez Fernández wrote:
> El 7/3/19 a las 20:58, Daniel Kiper escribió:
> > On Thu, Mar 07, 2019 at 07:05:20PM +0100, Jesús Diéguez Fernández wrote:
> >
> > [...]
> >
>
> [...]
>
> >> - And from a practical point of view, in case that I need to setup a
> >> custom handler for this, is it mandatory to ship the patch with it or
> >> could it be added later (maybe adding a TODO now)?
> >
> > I can accept this patch series without #GP handler if:
> >   - you add warning to the GRUB doc that #GP for rdmsr/wrmsr are not
> >     handled and system reboots; so, potential users have to be careful
> >     using these modules,
> >   - you add TODO notice to the code saying that generic #GP handling
> >     should be added to the GRUB code,
>
> That's what I had in mind.

Perfect!

> >   - you promise me that at some point, let's say after GRUB release,
> >     you will try to implement generic #GP handler.
> > > Is this acceptable for you?
> >
> > Daniel
> >
>
> I think that having a generic #GP handler is a nice improvement.
> As I said before, I don't know exactly the size of the rabbit hole I'm
> entering, so I can't guarantee a delivery date, but I do guarantee that
> I'll do my best.

I do not expect delivery date from you. I am asking you to work on this
issue. If you encounter any problems send us questions. We will try to
help. However, please do not drop the project in the middle without
informing us why. This is the worst think which can be done.

> GRUB is becoming very interesting to me, if you don't mind having a

Nice to hear that!

> newbie around here, maybe making one question or two sometimes, then we

Sure thing!

> have a deal. :)

We have the deal!

Daniel