[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/2] Add new MSR modules (rdmsr/wrmsr)

From: Daniel Kiper
Subject: Re: [PATCH v3 2/2] Add new MSR modules (rdmsr/wrmsr)
Date: Tue, 12 Mar 2019 20:12:59 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Fri, Mar 08, 2019 at 12:14:15PM +0100, Daniel Kiper wrote:
> On Fri, Mar 08, 2019 at 01:26:37AM +0100, Jesús Diéguez Fernández wrote:
> > In order to be able to read from and write to model-specific registers,
> > two new modules are added. They are i386 specific, as the cpuid module.
> >
> > rdmsr module registers the command rdmsr that allows reading from a MSR.
> > wrmsr module registers the command wrmsr that allows writing to a MSR.
> >
> > wrmsr module is disabled if UEFI secure boot is enabled.
> >
> > Please note that on SMP systems, interacting with a MSR that has a
> > scope per hardware thread, implies that the value only applies to
> > the particular cpu/core/thread that ran the command.
> >
> > Also, if you specify a reserved or unimplemented MSR address, it will
> > cause a general protection exception (which is not currently being handled)
> > and the system will reboot.
> >
> > Signed-off-by: Jesús Diéguez Fernández <address@hidden>
> LGTM. Reviewed-by: Daniel Kiper <address@hidden>
> There are a few comments nitpicks which I fix before committing the patches.
> If there are no objections I will commit the patches next week.
> Thank you for doing the work.

I had to tweak your patches because they broke build at least for coreboot
and x86-64 UEFI. Now they are in.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]