[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot

From: Colin Watson
Subject: Re: Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot
Date: Mon, 25 Mar 2019 17:02:27 +0000
User-agent: NeoMutt/20170113 (1.7.2)

On Mon, Mar 25, 2019 at 03:24:25PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> On Mon, Mar 25, 2019 at 12:58 PM Daniel Kiper <address@hidden> wrote:
> > Sadly this patch does not look complete. ./grub-core/lib/gnulib is still
> > included. And as Colin pointed out missing SOB.
> This directory still exists, at least in my copy. I didn't spend any
> time figuring out if this is intended or stale. In either case I don't
> want those file to accidently end up in POTFILES

grub-core/lib/gnulib/ exists and is supposed to exist; it consists of
automatically-maintained copies of the bits of Gnulib that GRUB actually
uses, as opposed to the clone of all of Gnulib that lives in the gnulib/
directory.  It shouldn't end up in POTFILES; so I think Daniel's point
is that you should exclude both gnulib/ and grub-core/lib/gnulib/ in
your patch.

Colin Watson                                       address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]