[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/8] travis: Add ARM thumb target to tests
From: |
Alexander Graf |
Subject: |
Re: [PATCH v2 7/8] travis: Add ARM thumb target to tests |
Date: |
Tue, 14 May 2019 06:32:06 -0700 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 14.05.19 12:05, Leif Lindholm wrote:
> Comment here as well:
>
> On Thu, May 02, 2019 at 08:55:36AM +0200, Alexander Graf wrote:
>> We hit an error case which only got triggered on ARM Thumb code. So
>> let's make sure we test that combination as well.
> This is the default for at least several and possibly most ARMv7-A
> distributions/prebuilt toolchains.
>
> So while a good idea, if you want to specifically force instruction
> set use, the opposite case needs to be set up with -marm.
>
>> Signed-off-by: Alexander Graf <address@hidden>
>> ---
>> .travis.yml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 8571d9f1c..d8f6170e6 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -106,6 +106,11 @@ matrix:
>> env:
>> - GRUB_TARGETS="arm-coreboot-vexpress arm-efi arm-uboot"
>> - CROSS_TARGETS="arm-linux-gnueabi"
> But, wait...
> arm-linux-gnueabi is the softfloat (v5te) toolchain - if we want to
> test that, fine - but we definitely need to test arm-linux-gnueabihf.
>
> First of all, I would expect that this toolchain will not use T32
> (Thumb-2) instructions by default, so much of the code will end up
> being compiled as A32 anyway.
Yeah, that's why we don't need to pass in -marm I guess. But I also
don't see an explicit hardfloat cross gcc on kernel.org?
https://mirrors.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/
Alex
[PATCH v2 8/8] travis: Test module loading from tftp as well, Alexander Graf, 2019/05/02
[PATCH v2 2/8] travis: Fix sparc64 test, Alexander Graf, 2019/05/02
[PATCH v2 4/8] travis: Fix arm coreboot test and make loop more robus, Alexander Graf, 2019/05/02
[PATCH v2 5/8] arm coreboot: Use common directory path, Alexander Graf, 2019/05/02