[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ia64: build fix in cache.h

From: John Paul Adrian Glaubitz
Subject: Re: [PATCH] ia64: build fix in cache.h
Date: Wed, 5 Jun 2019 00:11:00 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

On 6/4/19 8:51 PM, Leif Lindholm wrote:
> Add ia64 to the architectures excluding a declaration for
> grub_arch_sync_dma_caches.
> IA64 does not include any of the source files that require the function,
> but was overlooked for d8901e3ba115 ("cache: Fix compilation for ppc,
> sparc and arm64").
> Add it to the list of excluding architectures in order to not get
> missing symbol errors when running grub-mkimage.

Ah, now I get what the actual problem is. I'll test that tomorrow on real 

> -#if defined (__aarch64__) || defined (__powerpc__) || defined (__sparc__)
> +#if defined (__aarch64__) || defined (__powerpc__) || defined (__sparc__) || 
> \
> +    defined (__ia64__)

Nitpick, but could you actually put the arch names in alphabetical order?

It looks weird adding ia64 at the end when everything is already sorted.


 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - address@hidden
`. `'   Freie Universitaet Berlin - address@hidden
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

reply via email to

[Prev in Thread] Current Thread [Next in Thread]