grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] 30_os-prober: Provide GRUB_OS_PROBER_DISABLE_DEBUG


From: Colin Watson
Subject: Re: [PATCH] 30_os-prober: Provide GRUB_OS_PROBER_DISABLE_DEBUG
Date: Mon, 15 Jul 2019 17:26:55 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

On Mon, Jul 15, 2019 at 09:28:31AM +0000, Michael Chang wrote:
> This patch adds support to disable os-prober debug output while running
> grub-mkconfig through GRUB_OS_PROBER_DISABLE_DEBUG=true in simple
> configuration interface. The os-prober needs to support the
> OS_PROBER_DISABLE_DEBUG environment variable, which was introduced by
> 1.72 release.

Rather than extending the /etc/default/grub configuration interface for
this, I wonder if it would be better to just do something like this in
30_os-prober:

  export OS_PROBER_DISABLE_DEBUG="${OS_PROBER_DISABLE_DEBUG-y}"

That way, people who want details can set OS_PROBER_DISABLE_DEBUG= (i.e.
empty) when running grub-mkconfig, or we could add a --debug option or
something; but otherwise debug output will be suppressed, which seems
like a better default for grub-mkconfig.

-- 
Colin Watson                                       [address@hidden]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]