[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch that fixes an 'at_keyboard' module issue (unreliable key press
Re: Patch that fixes an 'at_keyboard' module issue (unreliable key presses)
Tue, 27 Aug 2019 11:57:02 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
On 8/24/19 9:09 PM, Michael Bideau wrote:
> This patch fixes an issue that prevented the 'at_keyboard' module to
> work (for me).
> The cause is a bad/wrong return value in the function
> 'grub_at_keyboard_getkey()' in file
> 'grub-core/term/at_keyboard.c' at line 234.
> ///////// patch /////////
> diff --git a/grub-core/term/at_keyboard.c b/grub-core/term/at_keyboard.c
> index f0a986eb1..597111077 100644
> --- a/grub-core/term/at_keyboard.c
> +++ b/grub-core/term/at_keyboard.c
> @@ -234,7 +234,7 @@ grub_at_keyboard_getkey (struct grub_term_input *term
> __attribute__ ((unused)))
> return GRUB_TERM_NO_KEY;
> if (! KEYBOARD_ISREADY (grub_inb (KEYBOARD_REG_STATUS)))
> - return -1;
> + return GRUB_TERM_NO_KEY;
> at_key = grub_inb (KEYBOARD_REG_DATA);
> old_led = ps2_state.led_status;
> ///////// end of patch /////////
> My symptoms were to have an unresponsive keyboard: keys needed to be
> pressed 10x and more to
> effectively be printed, sometimes generating multiple key presses
> (after 1 or 2 sec of no printing).
> Very problematic for typing passphrase in early stage (with
> When switching to 'console' terminal input, keyboard works perfectly.
> It also worked great with grub 2.02 packaged by Debian (2.02+dfsg1-20).
> It was not an output issue, but an input one.
Welcome, and thank you very much for your contribution.
I think I had a similar issue and tried to fix it in commit d3a3543a
(normal/menu: Do not treat error values as key presses) , present in
GRUB 2.04. Do you have that commit in your tree?
Description: S/MIME Cryptographic Signature