[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Fix bad test on GRUB_DISABLE_SUBMENU.

From: Daniel Kiper
Subject: Re: [PATCH v2] Fix bad test on GRUB_DISABLE_SUBMENU.
Date: Wed, 2 Oct 2019 14:15:26 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Mon, Sep 30, 2019 at 05:00:16PM +0200, Javier Martinez Canillas wrote:
> From: Prarit Bhargava <address@hidden>
> The GRUB_DISABLE_SUBMENU option is different than the others in the sense
> that it has to be set to "y" instead of "true" to be enabled.
> That causes a lot of confusion to users, some may wrongly set it to "true"
> expecting that will work the same than with most options, and some may set
> it to "yes" since for other options the value to set is a word and not a
> single character.
> This patch changes all the grub.d scripts using the GRUB_DISABLE_SUBMENU
> option, so they check if it was set to "true" instead of "y", making it
> consistent with all the other options.
> But to keep backward compatibility for users that set the option to "y" in
> /etc/default/grub file, keep testing for this value. And also do it for
> "yes", since it is a common mistake made by users caused by this option
> being inconsistent with the others.
> Signed-off-by: Prarit Bhargava <address@hidden>
> Signed-off-by: Javier Martinez Canillas <address@hidden>

Reviewed-by: Daniel Kiper <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]