[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] Add grub_util_readlink()

From: Javier Martinez Canillas
Subject: Re: [PATCH 1/2] Add grub_util_readlink()
Date: Mon, 28 Oct 2019 14:04:15 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

Hello Daniel,

On 10/23/19 11:19 AM, Daniel Kiper wrote:
> On Fri, Oct 18, 2019 at 02:42:20PM +0200, Javier Martinez Canillas wrote:
>> From: Peter Jones <address@hidden>
>> Add a grub_util_readlink() helper function.
> OK but for patches like that one I will be always asking for an explannation
> in the commit message why we need this functionality/function(s). So, please
> always add it. If you do that for this ptach feel free to add my RB.

Yes, sorry for missing that there wasn't an explanation about why the
change is needed. I've added now a proper commit message for v2.

Best regards,
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat

reply via email to

[Prev in Thread] Current Thread [Next in Thread]