[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/6] jsmn: Add convenience functions

From: Max Tottenham
Subject: Re: [PATCH 2/6] jsmn: Add convenience functions
Date: Mon, 4 Nov 2019 10:26:21 +0000
User-agent: Mutt/1.9.4 (2018-02-28)

On 11/02, Patrick Steinhardt wrote:
> The newly added jsmn library is a really bare-bones library that
> focusses on simplicity. Because of that, it is lacking some functions
> for convenience to abstract away some of its inner workings and to make
> code easier to read. As such, we're now adding some functions that are
> going to be used by the LUKS2 implementation later on.
> Signed-off-by: Patrick Steinhardt <address@hidden>
> ---
>  include/grub/jsmn.h | 108 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 108 insertions(+)

Would it not make sense to keep the additions in a separate header from
the vendored upstream library? That way it'll likely be easier to pull
in any updates.

Max Tottenham       | address@hidden
Senior Software Engineer, Server Platform Engineering
/(* Akamai Technologies

reply via email to

[Prev in Thread] Current Thread [Next in Thread]