[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/6] Support Argon2 KDF in LUKS2

From: Daniel Kiper
Subject: Re: [PATCH v2 0/6] Support Argon2 KDF in LUKS2
Date: Fri, 21 Feb 2020 13:26:20 +0100
User-agent: NeoMutt/20170113 (1.7.2)

Hi Patrick,

On Thu, Feb 20, 2020 at 07:00:48PM +0100, Patrick Steinhardt wrote:
> Hi,
> this is the second version of my patchset to add support for Argon2
> encryption keys for LUKS2.
> The most important change is that I've now verbosely imported the argon2
> code from the official reference implementation instead of from the
> cryptsetup project. The diff between both isn't that big in the end, and
> including from crypsetup's upstream seems a bit cleaner to me. There
> were several transformations required to use GRUB's types and functions
> as well as stripping of unused stuff, which I've now documented the dev
> manual. This also fixes my previously mistaken license headers.
> One thing I'm not sure about here is whether it's fine to declare the
> argon2 mod's license as GPLv3. The code is licensed under CC0/Apache
> 2.0, where the latter is compatible with GPLv3. But I don't know whether
> it's legit to just say "Yeah, this mod is a GPLv3 one".

Could you give me a reference to the doc/spec or what not which says that
it is legit to do that? I will consult this with GNU legal folks.

> I didn't address the comment made by Leif yet with regards to grabbing
> memory. I ain't got much of a clue of GRUB's memory subsystem, so I'd
> gladly accept help there. Otherwise I'll have to dig a bit deeper.

I will skip this part at this stage of review.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]