[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] build: Disable PIE in TARGET_CCASFLAGS if needed
From: |
Paul Menzel |
Subject: |
Re: [PATCH 2/2] build: Disable PIE in TARGET_CCASFLAGS if needed |
Date: |
Tue, 25 Feb 2020 11:58:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Dear Matt,
Thank you for upstreaming the patches.
On 2020-02-20 07:51, Matt Turner wrote:
> From: Mike Gilbert <address@hidden>
>
> PIE should be disabled in assembly sources as well, or else grub will
> fail to boot.
Could you please extend this with the list, on what architectures it
fails to boot? It seems to work on x86, doesn’t it?
> Bug: https://bugs.gentoo.org/667852
> ---
> configure.ac | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac b/configure.ac
> index b5e31c787..e2c783652 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1263,6 +1263,7 @@ grub_CHECK_LINK_PIE
> # `-fPIE' or '-fpie' and '-pie' in the default specs.
> if [ x"$pie_possible" = xyes ]; then
> TARGET_CFLAGS="$TARGET_CFLAGS -fno-PIE -fno-pie"
> + TARGET_CCASFLAGS="$TARGET_CCASFLAGS -fno-PIE -fno-pie"
> fi
>
> if [ x"$link_nopie_needed" = xyes ] || [ x"$pie_possible" = xyes ]; then
Kind regards,
Paul
smime.p7s
Description: S/MIME Cryptographic Signature