[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/10] kern/term: Accept ESC, F4 and holding SHIFT as user in

From: Javier Martinez Canillas
Subject: Re: [PATCH 07/10] kern/term: Accept ESC, F4 and holding SHIFT as user interrupt keys
Date: Sat, 14 Mar 2020 14:39:10 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/13/20 8:15 PM, Javier Martinez Canillas wrote:
> From: Hans de Goede <address@hidden>
> On some devices the ESC key is the hotkey to enter the BIOS/EFI setup
> screen, making it really hard to time pressing it right. Besides that
> ESC is also pretty hard to discover for a user who does not know it
> will unhide the menu.
> This commit makes F4, which used to be the hotkey to show the Windows
> boot menu during boot for a long long time, also interrupt sleeps /
> stop the menu countdown.

Hans pointed me out that this part of the commit message is wrong after
I modified his patch to use F4 as a hotkey instead of F8. I did this
because that was decided in the previous version of this patch:

But F4 is not a hotkey used by Windows so this whole paragraph should be
removed. And instead explain that F4 was chosen because is not used as a
hotkey to enter the BIOS setup by any vendor.

> +int
> +grub_key_is_interrupt (int key)
> +{
> +  /* ESC sometimes is the BIOS setup hotkey and may be hard to discover, also
> +     check F4, which was the key to get the Windows bootmenu for a long 
> time. */

And this comment should also be fixed since is wrong now.

I'll fix both issues on v2 but will wait first for review before doing that.

Best regards,
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat

reply via email to

[Prev in Thread] Current Thread [Next in Thread]